Skip to content

Add EL8/9 CernVM-FS repos#427

Merged
sjpb merged 1 commit into
mainfrom
add/cvmfs-repos
Aug 6, 2025
Merged

Add EL8/9 CernVM-FS repos#427
sjpb merged 1 commit into
mainfrom
add/cvmfs-repos

Conversation

@sjpb

@sjpb sjpb commented Aug 1, 2025

Copy link
Copy Markdown
Contributor

Used for Slurm appliance

@sjpb
sjpb requested a review from a team as a code owner August 1, 2025 12:59
@sjpb
sjpb force-pushed the add/cvmfs-repos branch 3 times, most recently from d9213c6 to 01a70e7 Compare August 1, 2025 13:31
priteau
priteau requested changes Aug 1, 2025
View reviewed changes
Comment thread ansible/inventory/group_vars/all/package-repos Outdated
priteau
priteau reviewed Aug 5, 2025
View reviewed changes

@priteau priteau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are pulling aarch64 instead of x86_64, is this right?

@sjpb
sjpb force-pushed the add/cvmfs-repos branch from 9a51670 to e15b55d Compare August 5, 2025 12:14
@sjpb

sjpb commented Aug 5, 2025

Copy link
Copy Markdown
Contributor Author

You are pulling aarch64 instead of x86_64, is this right?

No, massive fail, thank you now fixed.

@sjpb
sjpb requested a review from priteau August 5, 2025 12:15
priteau
priteau requested changes Aug 5, 2025
View reviewed changes

@priteau priteau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use https for the URL as well, it is available. Can you rebase it all into one commit while you're at it?

@sjpb

sjpb commented Aug 5, 2025

Copy link
Copy Markdown
Contributor Author

Please use https for the URL as well, it is available.

Well, it actually is, but it is not listed in any of the instructions. I'm trying to find out why that's not the preferred one.

Can you rebase it all into one commit while you're at it?

Squash+merge button appears to be available here, is that not sufficient?

@priteau

priteau commented Aug 5, 2025

Copy link
Copy Markdown
Member

Can you rebase it all into one commit while you're at it?

Squash+merge button appears to be available here, is that not sufficient?

I really don't like this as it generally produces ugly commit messages. As a contributor, it also makes it more complicated to find out what has been merged because it changes the commit hash.

@sjpb
sjpb force-pushed the add/cvmfs-repos branch from 99b6627 to b083879 Compare August 6, 2025 09:57
priteau
priteau approved these changes Aug 6, 2025
View reviewed changes

@priteau priteau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb
sjpb merged commit 0d938a2 into main Aug 6, 2025
3 checks passed
@sjpb
sjpb deleted the add/cvmfs-repos branch August 6, 2025 11:01
@sjpb sjpb mentioned this pull request Oct 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@priteau priteau priteau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sjpb @priteau